Game Patch didn't change
Closed this issue · 18 comments
Message in patch launcher:
In DF :
Nothing had changed, it still the old execute.
- In Path Execute File tab, when I added .po file, the encode not show code table listings.
- Did you not added VISCII table?
@klefo0 dfrus doesn't support 64-bit executables and is broken anyway, dfrus64 is not ready yet. I will try make at least partially working version of dfrus64.
Ok, thanks. But you should note it on the Readme.md.
@insolor I've found that in Python directory not have VISCII encode and encoding so I'm making one. Can you check it and add it to the requirements?
I've checked the code page you made, it cannot patch the translation into the game. And also why you choose utf16 but not utf8?
And also why you choose utf16 but not utf8?
DF internally converts text into utf16 using cp437 conversion table and then renders it. To add support of different encodings we must patch the conversion table. The new conversion table must map characters from the chosen encoding to uft16 too.
@insolor Maybe you should remove VISCII, then make a conversion table for cp1258
I've found a link talking about it: https://learn-tech-tips.blogspot.com/2016/03/how-to-read-tcvn3-character-in-any-process.html
@klefo0 for cp1258 support all marks under and above letters must be separated from letters, and I don't know yet if DF will be able to treat these separated marks properly. I will try to add this encoding in the future, but I do not promise anything.
I know, but the code page doesn't have all character in Vietnamese. So I think make a conversion table for it is a good idea, than make a code page in your code but it doesn't exist in Python directory
I know, but the code page doesn't have all character in Vietnamese.
Which one, viscii or cp1258?
So I think make a conversion table for it is a good idea, than make a code page in your code but it doesn't exist in Python directory
There are some cons and pros. On the one hand, viscii is already working, on the other hand, cp1258 support needs some additional effort to not break the support of other encodings (Cyrillic encodings, in particular). And I don't even know if cp1258 will work correctly.
Technically it is possible to support both (viscii and cp1258) encodings, but for now, I tend to leave it as it is.
Which one, viscii or cp1258?
The cp1258, but the viscii you wrote not working, so i made the encoding as I mention early.
viscii support is already fixed. The problem with patching of DF is not related to the viscii support.
Nope
Again: viscii encoding IS working. dfrus patcher is not working.
But i use df 32-bit
dfrus doesn't support 64-bit executables and is broken anyway,
Yes, so i change to df 32bit
dfrus is broken by itself, not because of missing viscii support. Even after you changed DF to 32 bit, it is still broken.
ok i understood