dfm/george

Unable to update values on a custom mean model.

arkottke opened this issue · 2 comments

arkottke commented

I implemented george.modeling.Model to provide a custom model. During optimization, it tries to call self.set_vector. I believe that this should be self.set_parameter_vector. The potential bug here:

for i, v in enumerate(vector):
    vector[i] = v + _EPS
    self.set_vector(vector)
    value = self.get_value(*args, **kwargs)
    vector[i] = v
    self.set_vector(vector)
    grad[i] = (value - value0) / _EPS
dfm commented

Yes - definitely a bug! This was fixed in #90 but I never merged that because I got too far behind on PRs :/ I'd be happy to accept an updated one directed at the main branch.

arkottke commented

Sure, I will send a PR to fix this issue.