Goto message by # fails badly when hitting deleted/other slots
dgets opened this issue · 4 comments
As seen in issue #179, as well as the following screenshot, trying to go to certain message numbers is still causing problems. In this case I believe that the message referenced was a deleted/purged message. A little bit of error handling around this should fix everything up pretty well.
Just need to determine now what kind of behavior we may want other than falling through back to the non-reading message prompt after displaying that next message. I suppose just displaying the one is 'good enough for now', but it really should throw things back into the read loop, which is going to be more work, as a lot of people start paging through that way.
Perhaps that's something to throw on the beyond beta changes list, as this is another implementation that I'm willing to handle right now for beta status.
According to the new scan method(-ology?) outlined at https://github.com/dgets/DOCshell/wiki/New-Message-Scan-Routine, it appears that we could potentially modify msg_base.readNew() in order to take an optional number and pass to that instead of to dispMsg(). That should take care of our entry into scanning/read mode with the appropriate prompts. Some code may still be needed in order to manipulate the current scan and last_read pointers for continuity, but I'll have to check that out to see how it's implemented from one of the other BBSen, or at least one of their experienced SysOps/users.