Why is the AsyncLoop not `.daemon = True` ?
alanjds opened this issue · 1 comments
alanjds commented
Line 9 in 228a7e9
If the thread is daemon you would need not to stop manually on Python exit.
Is there something bad on changing to .daemon = True
or should a PR land here?
dgkim5360 commented
The reason is simply because I haven't been aware of the daemon
feature of threading.Thread
. :>
I figured out that this daemonizing feature nicely destroyed the AsyncLoop
thread as you said, coding in this way:
class AsyncLoop(threading.Thread):
def __init__(self, maxsize=100):
super().__init__(daemon=True)
I welcome your PR! And thank you for the first issue.