dgtlmoon/changedetection.io

Email name= and from= are synonymous?

Closed this issue · 1 comments

dokgu commented

Describe the bug
When setting up an email notification and I use both name= and from= query parameters, I get this warning:

WARNING - Email name= and from= are synonymous; use one or the other.

This seems to be incorrect because when I remove name=, what shows on my email client is no.reply if my from= is set to no.reply@domain.com. If I use both query parameters I get more control on what name the email client displays - No Reply - Domain instead of no.reply.

Version
v0.48.01

How did you install?
Docker

To Reproduce

Steps to reproduce the behavior:

  1. Create a new monitor and on the notification URL list, add:
mailtos://<username>:<password>@<domain>?smtp=<host>&from=no.reply@domain.com&name=NoReply&to=<email>

Additional context
The name= is not synonymous to the from= parameter as those serve two different purposes. Having those two supplied on the notification URL list results in a warning therefore resulting in a notification error label after the monitor runs and sends an alert. This is misleading because the email goes through without any issues and those two aren't really synonymous.

We are using 'apprise' for the email part, so this is not our code, however their documentation says that name= is redundant because from= supports me@home.com

https://github.com/caronc/apprise/wiki/Notify_email

"

With respect to {from_email}, this allows you to provide a name with your Reply-To address.
Note: This field has become redundant and become synonymous to from=. It still behaves as it did in previous versions, but you can also follow the A User<user@email.com> syntax as well. To eliminate ambiguity; the values parsed from the from= will always trump the name=.
"