dhis2/settings-app

Number validator isn't working correctly

Closed this issue · 5 comments

Steps to reproduce:

  1. Change the "Data analysis std dev factor" field in the "General" settings section
  2. Any value gives the error "This field should be a number" and the setting isn't saved
adhbh commented

Gets fixed in this adhbh/d2-ui@06c91db

Kindly review :)

Ah, i see this has already been fixed. Still seems to be present in the dev demo.

@jason-p-pickering Yes it's fixed, but I haven't deployed a new version to trunk yet. I'll probably do that later today.

Also, in this case, the number should be greater than zero. Negative and zero standard deviations don't really make any sense.

Good point