dial-once/node-cache-manager-redis

Handle reconnect when Redis connection is lost

PuKoren opened this issue · 8 comments

Handle reconnect when Redis connection is lost

Related to #5

After a conversation on slack and testing we saw that redis does get reconnected on default settings and that the possible bottleneck could be sol-redis-pool module that restricts some redis options being passed into it. One example joshuah/sol-redis-pool#17

So @jkernech @PuKoren Any ideas on how to proceed (or close this issue) ?

@mrister can you describe the test processed?

What do you mean by bottleneck on sol-redis-pool? The underlying redis is reconnected and sol-redis-pool acts if it was still disconnected?

@PuKoren Sure:
For sol redis poll it does not pass options to redis (like the PR i sent) which control reconnect and retry strategies

Test was:

  • Start a redis cache via redis-node-cache-manager
  • Do some sets and gets of a same key to make sure it is working
  • Disable redis
  • Do some sets and gets
  • Restart redis
  • Do gets and sets to make sure it is working.

Reconnect happened as well as operations got queued while server was down.

Well if it is working as expected you can close the issue

@jkernech You did some investigations also, what do you think, ok to close ?

@mrister Ok to close, I couldn't reproduce the issue

Closing as discussed.