dial-once/node-cache-manager-redis

cache-manager 1.2 breaking update?

amit777 opened this issue · 4 comments

amit777 commented

Hi, I posted this issue in the main cache-manager project, but it's not clear to me yet whether it's a problem there or here:

jaredwray/cacheable#34

thanks!

jkernech commented

Thanks @amit777. I'll check this out soon.

jkernech commented

The problem was related to the multiCaching in node-cache-manager. The isCacheableValue function of the underlying cache was never called.

This PR should fix the issue jaredwray/cacheable#35

BryanDonovan commented

1.2.1 should fix this so you don't have to set the isCacheableValue() in the multiCaching initialization since it will now use the redis cache store's isCacheableValue().