dictation-toolbox/Caster

keyboard grammar does not hold a series of modifier keys

LexiconCode opened this issue · 2 comments

Issuehunt badges

Describe the bug
Keyboard command with the hold/release modifier for a series keypresses is not recognized is not a valid command.
The modifier key combos are not included in the button_dictionary_1. Some thought will have to begin how to include them whether it's in button_dictionary_1or something else.

To Reproduce
Steps to reproduce the behavior (be sure to include the exact command phrase you are using):
Test case 1

  1. Start the test engine
  2. Say 'hold control shift'
  3. command not recognized

Test case 2

  1. Say 'control shift'
  2. command recognized

Expected behavior
hold modifiers should work as expected

There are issues modifying command as the following:

        "<hold_release> (<modifier> | <button_dictionary_1>)":
              R(Key("%(modifier)s | %(button_dictionary_1)s:%(hold_release)s"),
              rdescript="%(hold_release)s button: %(button_dictionary_1)s"),             
  • modifier choice objects to be valid keypresses would need the character - removed
  • Duplicate single modifier keys between button_dictionary_1 and modifier
  • Passing the correct keys to rdescript with optional (<modifier> | <button_dictionary_1>) choice objects

IssueHunt Summary

lexiconcode lexiconcode has been rewarded.

Backers (Total: $100.00)

Submitted pull Requests


Tips

@itsrainingschmen has funded $100.00 to this issue.


@lexiconcode has rewarded $90.00 to @lexiconcode. See it on IssueHunt

  • 💰 Total deposit: $100.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $10.00