Not Working: Firefox 46.0.x
Opened this issue · 18 comments
The addon is no longer working for me. I've tested it with Firefox/Cyberfox 46.0. It does, however, work in Waterfox 43.0, so it seems to only be an issue with recent versions.
Let me know if you need other information.
Thanks.
i'm experiencing the same - not working in 46
FF 46
CL 2.7.1
Linux
example page: https://archive.is/Pa8hn - see the "Read more" link near the bottom
I am also seeing the same thing (CyberFox v46.x)
another related problem i'm seeing is problems with the toolbar button - when i dragged the button on to the toolbar CL began working, at least in some instances, though the list of cleaned links may or may not be present in the button context menu
UNSUBSCRIBE
Hi guys, thanks for bringing that to my attention.
Do you see any error related to CL in the browser console? (you can open it using ctrl+shift+j)
I do not see any CL errors or warnings in the browser console.
The CL icon will stay grey (off) after being pressed once and does not come back on again when pressed again.
The current session list stays empty.
There is NO highlight style applied (when Event Delegation mode is off and Link Tracking is on)
I think the link is cleaned when testing on Google images (encrypted) - but I am not 100% certain about it.
I have removed, reset & reinstalled CL to test - Cyberfox x64 (v46.3)
I don`t know if any of this information is useful.
i can confirm what @GitCurious says - cool nick by the way :)
the toolbar icon acts strange when enabling/disabling it and the context menu list may or may not display the cleaned links, even when cleaning has been done (evident by the highlight style)
also for the test link i provided (https://archive.is/Pa8hn), CL is now working with that page - it may have started working after i placed the CL icon on the toolbar (i didn't put it there after installing CL because i didn't want/need it)
I think I have discovered the reason for this strange behaviour....in my case at least.
I recently restored a backup Cyberfox profile in which I had previously enabled the e10s settings for testing reasons.
I have now disabled the e10s settings and CL appears to be working again.
browser.tabs.remote.autostart is false in my case
I have just remembered that someone else reported some issue when the toolbar icon/button is customized outside of the main browser toolbar, so certainly that could be one reason :-/
Additional rules of thumb are:
- Use Event Delegation mode (the DOM traversal one is outdated/obsolete, not further improved in a long time nor tested on newer Firefox versions)
- Electrolysis/e10s is not yet supported, hence CL won't work while it's enabled.
If problems still persists, you can give a try the version 2.8a1 available here on Github, to install it you can use the GitHubExtIns extension - fwiw, i'm using that version on Fx 46 with no issues at all.
Hope that helps, and thanks for the follow ups 👍
Will e10s be supported?
Yes, e10s will be supported, but i won't start working on it until its integration on the stable channel/release of Firefox is imminent.
Isn't e10s already the default in Fennec/FFox for Mobile since forever?
It is? Dunno, I didn't played with Fennec for quite some time.
Apparently there seems to be several e10s-related bugs still open:
Note that e10s is planned to ship with next release (19 July).
Thanks for bringing that to my attention, although it isn't the first time I hear that :)
If it does really ships with the next release, expect e10s support in CL a few days later.
I just wonder why you are going to break the Add-On for those days instead of already providing a new version that can be tested now.
Time has shown that prematurely working on supporting a new/breaking feature could be a waste of time, because their implementation/specification could change at any time - i faced this multiple times, so I ended up only working on them when fully established (I.e. hitting the stable channel)