diegopvlk/Dosage

Snap package discussion

Closed this issue · 19 comments

Thank you for the snap package. Feel free to mention me, with any issue with the snap. BTW, you can have workflows for the snap to test if it builds or not.

BTW, just noticed, so, letting you know, plug login-session-observe doesn't auto connect. You'll need to make a request in the forum asking for it to auto connect.

Thank you for the snapcraft.yaml :)

So is login-session-observe unnecessary? Does it do the same thing as dbus session?

Another thing I noticed is that the notification icons are not showing properly, do I need something extra to show symbolic icons? They're not showing on the top bar (app menu) either.

So is login-session-observe unnecessary? Does it do the same thing as dbus session?

https://github.com/diegopvlk/Dosage/blob/main/io.github.diegopvlk.Dosage.json#L12

As much I know from the docs, it's the snap equivalent to this of flatpak. So, you need to go and make a request in the forum for making this plug auto connect, else, this plug needs to be manually connected. It's the like the process of security checking, simply because this is a sensitive plug.

Another thing I noticed is that the notification icons are not showing properly, do I need something extra to show symbolic icons? They're not showing on the top bar (app menu) either.

Can you show me the actual icons you want? I don't have a non ubuntu installation to test with.

BTW, notification doesn't seem to be working. No idea why, in my tests it did.

I just need to check if the system is returned from suspension. From my tests it seems to be working, which I assume is because of the dbus in slots:

slots:
dosage-tracker:
interface: dbus
bus: session

This is where it's used:

_handleSuspension() {

Since it's working without login-session-observe being active I guess it can be safely removed.

Can you show me the actual icons you want? I don't have a non ubuntu installation to test with.

https://github.com/diegopvlk/Dosage/blob/main/data/icons/hicolor/symbolic/apps/io.github.diegopvlk.Dosage-symbolic.svg

It's just the symbolic icon for the app, it shows on the app menu and notifications, I didn't need to do anything special in the flatpak, it just works normally. In the snap it shows like this:

image

BTW, notification doesn't seem to be working. No idea why, in my tests it did.

For me it's working fine, tested on my machine with fedora and in a vm with ubuntu 22.04, so not sure what's wrong.

I just need to check if the system is returned from suspension. From my tests it seems to be working, which I assume is because of the dbus in slots:

I think it's necessary. Though, I am not able to reproduce the user case. But, to talk with org.freedesktop.login1.Manager, you must need this plug.
https://github.com/snapcore/snapd/blob/master/interfaces/builtin/login_session_observe.go

It's just the symbolic icon for the app, it shows on the app menu and notifications, I didn't need to do anything special in the flatpak, it just works normally. In the snap it shows like this:

Got it, snaps hardcode the desktop icon path, simply because Unity often faces issues with themed desktop icon. And as gnome has also ditched it with gnome 45, I think you should not think too much about it.

For me it's working fine, tested on my machine with fedora and in a vm with ubuntu 22.04, so not sure what's wrong.

Well, it was my fault. I set the timings wrong to test with.

But, to talk with org.freedesktop.login1.Manager, you must need this plug.

Ok then

Though, I am not able to reproduce the user case

Set a treatment for today and a time less than now.
Make sure there is no notifications showing and suspend your pc.
After waking from suspension, see if there is a new notification, if yes, it means it's working.

Got it, snaps hardcode the desktop icon path, simply because Unity often faces issues with themed desktop icon. And as gnome has also ditched it with gnome 45, I think you should not think too much about it.

I don't care about the app menu icon. But eventually I want to show the custom icon in the notification (haven't figure it out how yet). So I would prefer that at least this one works.

I don't care about the app menu icon. But eventually I want to show the custom icon in the notification (haven't figure it out how yet). So I would prefer that at least this one works.

Yeah obviously they will. This is done in the desktop file and nothing related to your app. Check in /var/lib/snapd/desktop/applications/dosage-tracker_dosage_tracker.desktop

EDIT: Confirmed, login-session-observe is needed.

Confirmed, login-session-observe is needed.

Then it's a mystery on how it's working for me
image

But I'll make the request anyway

Then it's a mystery on how it's working for me

Is this the vm of ubuntu or any other distro?

Is this the vm of ubuntu or any other distro?

This is a pc with fedora 39. I can't test in a vm, suspension doesn't work.

This is a pc with fedora 39. I can't test in a vm, suspension doesn't work.

Probably you haven't setup the confinement properly in fedora. Replacing the SeLinux, is tough in fedora. So, the confinement didn't work properly.

@soumyaDghosh Hey, do you know what are the necessary changes to make for Libadwaita 1.6/GNOME 46?

@soumyaDghosh Hey, do you know what are the necessary changes to make for Libadwaita 1.6/GNOME 46?

Until libadwaita 1.6 is officially released it'll not be added into the gnome-sdk. When it's official, it'll added, if you want to use prerelease, you can build it from the source. Also, core24 is coming soon. You should upgrade to that also when released.

Also, core24 is coming soon

Got it

Until libadwaita 1.6 is officially released

It was released today. So I don't have to do anything, just wait for ubuntu/gnome-sdk/ to update?

It was released today. So I don't have to do anything, just wait for ubuntu/gnome-sdk/ to update?

Exactly. It'll be updated and pushed to the users soon.

@soumyaDghosh Thanks!

BTW, I guess you mean libadwaita 1.5?

BTW, I guess you mean libadwaita 1.5?

Ops, yes 1.5

@diegopvlk

ubuntu/gnome-sdk#198

Also I think better to move this issue to a discussion