Replace style code with stylesheet

Question

Replace style code with stylesheet

RomanMatthew opened this issue 5 years ago · 12 comments

👍

Answer 1 · 2019-06-13T16:09:20.000Z

you can cross reference the PR where this is discussed for future reference.... crossref #14 for more discussion on this.

Answer 2 · 2019-07-09T18:43:53.000Z

@CJ-Wright @chiahaoliu I'm still not sure what needs to be done here, but this seems like something we could nix quickly. Thoughts?

Answer 3 · 2019-07-09T18:45:49.000Z

https://matplotlib.org/users/style_sheets.html

Answer 4 · 2019-07-09T19:39:05.000Z

whether we put this issue on the milestone depends a bit on what is involved. It is a good time to do it now (its the right thing to do, this is the first major release), but I also don't want to slow things down too much. Can we get an assessment from @RomanMatthew about how much is involved here?

…

On Tue, Jul 9, 2019 at 2:45 PM Christopher J. Wright < ***@***.***> wrote: https://matplotlib.org/users/style_sheets.html — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16?email_source=notifications&email_token=ABAOWUIG5EKCCC4LXZ6S7G3P6TMF3A5CNFSM4HX3BDRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZRFKYA#issuecomment-509760864>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABAOWUJXNA26XYSFHA6BN33P6TMF3ANCNFSM4HX3BDRA> .

-- Prof. Simon Billinge Applied Physics & Applied Mathematics Columbia University 500 West 120th Street Room 200 Mudd, MC 4701 New York, NY 10027 Tel: (212)-854-2918 (o) 851-7428 (lab) Condensed Matter Physics and Materials Science Dept. Brookhaven National Laboratory P.O. Box 5000 Upton, NY 11973-5000 (631)-344-5661 email: sb2896 at columbia dot edu home: http:// <http://nirt.pa.msu.edu/>bgsite.apam.columbia.edu/

Answer 5 · 2019-07-15T19:53:44.000Z

What are your thoughts about what to do versus not do? It sounds like using a style sheet might be the right move but do we want to hard code it in or include the guide? Also in #14 we discussed making the bg stylesheet available via url and then including the url - if that's the plan, where can I find the BillingeGroup stylesheet and how do we package it with the software?

It doesn't seem like it would be too much, but a little more guidance and I should be able to get it done!

Answer 6 · 2019-07-15T22:07:20.000Z

The current style-sheet is in https://github.com/Billingegroup/mpl-stylesheets The best would be for you to fork and clone that and play around with plotting using it to see if it makes better looking plots. We can link to it dynamically using a URL, but this could give poor behavior, for example your local PDFmorph doesn't work when you are offline or github is down. So for now, we could just add a version of the style-sheet into the repo. But before we do, let's make sure that it makes nice looking plots!

…

On Mon, Jul 15, 2019 at 3:53 PM RomanMatthew ***@***.***> wrote: What are your thoughts about what to do versus not do? It sounds like using a style sheet might be the right move but do we want to hard code it in or include the guide? Also in #14 <#14> we discussed making the bg stylesheet available via url and then including the url - if that's the plan, where can I find the BillingeGroup stylesheet and how do we package it with the software? It doesn't seem like it would be too much, but a little more guidance and I should be able to get it done! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16?email_source=notifications&email_token=ABAOWULZGGXHQ2ND73LZNVTP7TIURA5CNFSM4HX3BDRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6Y7KA#issuecomment-511545256>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABAOWULXU54UTXNLSAT3GR3P7TIURANCNFSM4HX3BDRA> .

Answer 7 · 2019-07-18T20:37:07.000Z

After some experimentation, I'm not sure about the necessity of a stylesheet since all the changes I'm making are pretty trivial on average. Unless you have any preferences for different colors in the plots, I think they look distinct and good as-is!

Answer 8 · 2019-07-19T00:58:41.000Z

This is more of a branding issue. If the plots are taking their style from a style-sheet and we update the style-sheet, all plots will update in the same way. So it is not so much about how many or how few things are being set. But if it is a huge hurdle to jump, it is not such a big deal.

Answer 9 · 2019-07-19T19:07:08.000Z

I think it's a little more involved than I can figure out in a timely manner, but I would keep it on the radar

Answer 10 · 2019-07-19T23:23:39.000Z

ok, that's fine. let's remove it from the release milestone. IT is something I want to implement group-wide, but if it is not easy we don't need to hold this up for that.

…

On Fri, Jul 19, 2019 at 3:07 PM RomanMatthew ***@***.***> wrote: I think it's a little more involved than I can figure out in a timely manner, but I would keep it on the radar — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16?email_source=notifications&email_token=ABAOWUNXLJRFNJOUEWI7KGTQAIGFZA5CNFSM4HX3BDRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2MPZHY#issuecomment-513342623>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABAOWULYTHXEGNLMSXZYPOTQAIGFZANCNFSM4HX3BDRA> .

Answer 11 · 2022-11-17T21:56:53.000Z

this will be closed by #50