digital-asset/ghc-lib

GitHub actions disabled?

Closed this issue · 9 comments

shayne-fletcher commented

there are a couple of github workflows in the repo but they don't run on push. is this international? some config disabling actions?

@garyverhaegen-da

shayne-fletcher commented

with #539 there is now a complete set of builds via github actions available such that if enabled, azure config can be removed and the project would be migrated over.

shayne-fletcher commented

also worth noting that github builds take 50% of the azure build time.

paulbrauner-da commented

Hi Shayne. Yes, github actions are disabled. We're looking into enabling them but in the meantime we have some questions on #540 (which seems to be the new version of #539).

  • 👍1
shayne-fletcher commented

in #540 (comment) we talk about how we don't have a --da test (da-ghc-8.8.1) workflow.

if we make the jump to github now as i advocate we'll have to work out how much we care about not having that build signal.

personally, i'm ok with it. linux + windows for that build is convincing enough for me. if there were going to be problems for DA, downstream testing would quickly show it. if on other hand we do care enough we could just keep the azure config for this one build.

lastly of course there's no intention to remove support for running the build locally (or on corporate infra) assuming you have a >= 8.4 darwin x86_64 environment so we're not contemplating losing anything with respect to our ability to running it

paulbrauner-da commented

Github actions are now enabled, see #540 (comment).

shayne-fletcher commented

not quite. you can see from https://github.com/shayne-fletcher/ghc-lib/actions/runs/9992917978 for example that @nycnewman 's c8ce1c7 caused actions to run on my fork but there still appears to be no jobs running on the repo itself.

shayne-fletcher commented

in #540 (comment) we talk about how we don't have a --da test (da-ghc-8.8.1) workflow.

if we make the jump to github now as i advocate we'll have to work out how much we care about not having that build signal.

personally, i'm ok with it. linux + windows for that build is convincing enough for me. if there were going to be problems for DA, downstream testing would quickly show it. if on other hand we do care enough we could just keep the azure config for this one build.

lastly of course there's no intention to remove support for running the build locally (or on corporate infra) assuming you have a >= 8.4 darwin x86_64 environment so we're not contemplating losing anything with respect to our ability to running it

i have a fix for this. when the repo is fixed such that i can get changes landed again i'll put up a PR.

shayne-fletcher commented

i have a fix for this. when the repo is fixed such that i can get changes landed again i'll put up a PR.

#543