Relabel legacy `collection=` parameter in `calculate_bandindices`

Question

eefaye opened this issue 3 years ago · 0 comments

calculate_bandindices currently requires the collection= parameter which must be specified as either c2 or s2.

c2 refers to "Collection 2" for Landsat but DEAfrica no longer indexes Collection 1 data so this association is unintuitive.

s2 refers to "Sentinel-2", which is not a "collection" in the Landsat sense but a different sensor altogether.

Proposed actions

Rename c2 to ls
Rename collection= to sensor= or similar
Edit all notebooks where bandindices is used and make note of the change where appropriate