use underline rather than bottom border for links
Closed this issue · 2 comments
dwhieb commented
use underline rather than bottom border for links
vadekh commented
Looks like the link class currently uses text-decoration: underline; text-underline-position: under; on :hover. Is that the part that needs changing?
dwhieb commented
No that's exactly what it should be! I think I just misinterpreted what I was looking at. I'll close this issue.
For context, native underline styling in browsers used to be not great for readability, so developers typically used a border-bottom instead. It had its own issues, but it was an improvement. Now that the text-underline-position rule is supported in browsers, native underline styles are much nicer. An older version of the .link style had border-bottom, and I forgot that I'd already updated it.