Deploy as Helm chart
tyranron opened this issue · 7 comments
It would be nice to have an ability to deploy this CSI driver via Helm chart instead of raw Kubernetes manifests. Is it something desirable to be contributed?
I would have no objections to adding a helm chart. Interested in @timoreimann's opinion as well.
My only request if we add a helm chart is that we still provide static manifests for those who choose to install that way, and that those static manifests are generated from the helm chart in an automated or semi-automated way for each release (at the very least, we add a CI check that prevents them from being modified separately). I think our static manifests are probably sufficient for the majority of users, but maintaining two separate sets of deployment manifests is obviously a bad idea.
Hey @tyranron 👋
agreeing to all points that @adamwg raised. Something I'm not too familiar with is whether Helm charts should be hosted in this repo, or whether there's possibly a more central place. I'm okay with whatever is state-of-the-Helm-art today.
We do not consume Helm charts internally at DO for the CSI driver, so the best way to support them is for an external contributor to make the initial contribution -- PRs welcome.
Hi @timoreimann,
I was thinking that I can pick this up. Since a lot of projects are hosting the helm charts in their own repo now a days, we can consider hosting the chart here itself.
What do you think?
@viveksinghggits sounds good to me. Feel free to take a stab, I'd be happy to review.
@timoreimann @viveksinghggits actually, I have some ready Helm chart, which we use internally. So for @viveksinghggits not having a fresh start, I'll issue a PR shortly, where will give him access to the branch.
@tyranron
that makes sense. Thanks.
Hey @tyranron/ @timoreimann ,
I thought that I would be able to work on this, but considering recent commitments at work it looks like I will not be able to work on this.