digitalpianism/testframework

Change scope for properties in DigitalPianism_TestFramework_Model_Config

Opened this issue · 2 comments

marcinwarzybok commented

Hello,

Is this possible to change scope (from private to protected) for properties in DigitalPianism_TestFramework_Model_Config ($modelTestDoubles, $resourceModelTestDoubles) ?
I want extend DigitalPianism_TestFramework_Model_Config in my own Config file and work on framework properties.
Of course I can make pull request for it.

digitalpianism commented

@marcinwarzybok yeah sure, go for it. I'll merge as soon as I get your PR

tim-bezhashvyly commented

Protected properties are evil and must be avoided.