digitalroute/cz-conventional-changelog-for-jira

Not getting type of change in new version 7.5.0

VishalMathimaran opened this issue ยท 5 comments

Not getting type of change option during commit from newer version. Is there a new flag for enabling this?
Screenshot -> https://drive.google.com/file/d/1TpF4flxAhVagIrQyodH9Jq88UyPJjBMX/view?usp=sharing

Hi! That looks like a bug to me. I think it's because of this line.

@s-hoff could you please submit a fix in a new PR?

Done, I must have somehow missed that.

Maybe its worth also covering this in the tests? Moving that into a function which would be used to build the options in the existing tests would mean they all cover regressions from introducing new options.

Maybe its worth also covering this in the tests? Moving that into a function which would be used to build the options in the existing tests would mean they all cover regressions from introducing new options.

Yeah that makes sense! I agree. I wonder how though ๐Ÿค” It's easy to risk just creating tests that work exactly the same as the business logic.

๐ŸŽ‰ This issue has been resolved in version 7.5.1 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

Maybe its worth also covering this in the tests? Moving that into a function which would be used to build the options in the existing tests would mean they all cover regressions from introducing new options.

Yeah that makes sense! I agree. I wonder how though ๐Ÿค” It's easy to risk just creating tests that work exactly the same as the business logic.

Thats the Idea behind not making new test cases that go after the options in isolation but rather using the same function to get them for the existing engine tests as well. That way, anything here that influences the existing functionality will break them. In a way they would become more of an integration then unit test suite, which is fine given that they still run just as fast and should not loose much precision for funsing the causes.

If its just the options function I agree, it wonโ€™t help especially when adding new options.