diptopandit/BatSim

Important Hints

Opened this issue · 1 comments

I checked out this project and made some tests. It is good.
Hints:

  1. I Suggest you add the it URL on README.md file
  2. Its important to explain on README.md how to build and what O.Ss it source code supports. Good (Windows and Linux)
  3. Its important to show the battery charge percentage when using get status command
  4. Its important to show the extimated battery available time until it be uncharged according woth load when running
  5. add .gitignore file with entry .o and *.user to make QtCreator user setting be not part of commits
  6. I have added a BatSim.pro to allow it be builedd by QtCreator IDE and it make easy to navigate:
    ==== Begin: BatSim.pro ====
    TEMPLATE =
    TARGET = batsim
    SOURCES +=
    src/simulator.cpp
    src/cparser.cpp
    src/cell.cpp
    src/batsim.cpp
    src/battery.cpp
    HEADERS +=
    includes/simulator.hpp
    includes/cparser.hpp
    includes/cell.hpp
    includes/batsim.hpp
    includes/battery.hpp

DISTFILES +=
Doxyfile
LICENSE
README.md
==== End: BatSim.pro ====

Hi Jose,
Thanks for showing interest on this. It was stared as a small experiment for personal use and not maintained anymore.
However, I will try to make it more usable to public and surely consider your suggestions.
BTW, if you have made any changes, feel free to create a pull request.