Consolidate Masking Logic
Closed this issue · 1 comments
The logic for computing masks is spread over multiple C++ and python files including raw_image.cpp
, layered_image.cpp
, image_stack.cpp
, and masking.py
. As we look to move much of the masking out of the core KBMOD search (and make it a preprocessing step), it would be cleaner to consolidate this logic in a single location outside of (at least) the image data structures.
One example implementation would be to create a masking class in C++ (modeled off the python class) or extend the current python class that takes an ImageStack
and performs masking on all images in it. This class could be overloaded to perform the different types of masking (threshold masking, bitmask masking, etc.). Note the dictionary -> bitmask code should stay in python.
Closed by #424