direct-connect/go-dcpp

NMDC searches always delivered as passive

aler9 opened this issue · 2 comments

aler9 commented

Hi, i was working on automated tests between dctk and go-dcpp, and i noticed that all NMDC search requests, active or passive, are transformed into passive ones, making validation impossible.

This behavior is also described in comments, but no reasons are provided:

// ignore some parameters - all searches will be delivered as passive

What's the reason of this choice?
If this is just a WIP i can write a patch that implements active searches.

Thanks

This is intentional. Passive search is the only way to allow users from both protocols on the same hub to search reliably.

aler9 commented

ok, thanks