dirs-dev/directories-rs

Consider the Rust API Guidelines

dwijnand opened this issue · 5 comments

https://rust-lang-nursery.github.io/api-guidelines/

just sharing what I came across. perhaps you're already aware of them.

soc commented

Thanks, I'll have a look! Did you find anything that was in violation of the guidelines?

Perfect timing by the way, was just giving a talk about this library. :-)

soc commented

@dwijnand Is there any specific recommendation you want to point out?

nope, just thought you'd be interested.

I've yet to find the time to sit down and read through it all myself.

feel free to close this issue as and when you please - I don't have any specific outcome attached to it.

soc commented

Ah, ok thanks! I went through it, but I couldn't find a recommendation that the code was violating.

feel free to close this issue as and when you please - I don't have any specific outcome attached to it.

Then I'll close this for the moment, but please reopen this at any time you feel there is something that can be improved.

Thanks!