Dependency management

Question

Dependency management

Closed this issue 6 years ago · 3 comments

pmoust commented 7 years ago

Currently there's no dependency management.

Some library pinning and/or dep vendoring would be helpful.

Answer 1 · 2018-01-08T20:38:30.000Z

All it needs is a requirements.txt, no?

Answer 2 · 2018-01-10T00:54:49.000Z

@pmoust the main reason we don't have anything at the moment is there is realistically only two dependencies, elastic (which is sanely versioned by tag via gopkg) and github.com/oschwald/geoip2-golang (which hasn't been updated since April 2017).

I'd be open to vendoring geoip2 if someone would like to PR that, I think for now depending on the elastic tag should be good (and if it breaks we can revisit).

Answer 3 · 2018-01-10T01:04:51.000Z

Ah I forgot github.com/DataDog/datadog-go/statsd, which can probably also be vendored.