discuitnet/discuit

[BUG] Font issues

Closed this issue · 4 comments

noClaps commented

I'll keep adding new comments as they come, but these should be extracted into their own issues and fixed.

ttaylor-st commented

Font rendering incorrectly

I'm fairly certain this is caused by a regression in WebKit where it's not automatically setting the optical size. Should only affect Safari 16.0-16.4 on iOS + macOS

We could either:

  • modify Inter, to "remove the named instances with a non-default opsz." (source),
  • or explicitly state opsz in font-variation-settings for the affected versions
noClaps commented

I vote for stating opsz in our CSS. Maybe an issue can be opened in the Inter repo for this, but modifying Inter ourselves means we'll have to maintain that change through all future versions.

According to the WebKit bug report this seems to have been fixed last year. I'm not sure how much responsibility we should take to maintain compatibility with older versions of browsers. Safari 17 has been out for a while now, most people have probably updated to it.

  • 👍2
ttaylor-st commented
  • 👍1