divan/depscheck

Incorrect LOC used in presence of multiple levels of indirection

NHOrus opened this issue · 1 comments

Or depscheck report Lumberjack as a good candidate for removing from dependencies, when it isn't:

 - Package lumberjack (gopkg.in/natefinch/lumberjack.v2) is a good candidate for removing from dependencies.

   Only 0 LOC used, in 1 calls, with 0 level of nesting

Standard usage pattern of Lumberjack is, to quote readme,

log.SetOutput(&lumberjack.Logger{
    Filename:   "/var/log/myapp/foo.log",
    MaxSize:    500, // megabytes
    MaxBackups: 3,
    MaxAge:     28, //days
})

with log interacting with inner implementation of lumberjack.Logger as io.WriteCloser.
This is misleading, and may be a good candidate to improve code or add as example of false positive in Readme.

divan commented

Oh, nice example, thanks! I'll investigate it.