Split code into Client and Server parts.

Question

Closed this issue 11 years ago · 10 comments

Answer 1 · 2014-05-13T04:25:20.000Z

@oeuillot Mind taking a look at this?

Answer 2 · 2014-05-13T07:52:52.000Z

Good work (I comment in #10 )

Answer 3 · 2014-05-14T04:18:03.000Z

Does this address your issues?

Answer 4 · 2014-05-14T07:56:46.000Z

Hello,

My main problem is :

process.on('exit', self.stop.bind(this))

I suggest you to put this code outside, in the samples, not in the library.

Regards,

Answer 5 · 2014-05-14T14:51:48.000Z

Yeah, I forgot to remove it. It's gone now.

Answer 6 · 2014-05-14T15:10:47.000Z

Cool ..
You can add a comment in the sample to add a process.on('exit').
Thanks, alert-me when you have a release version !

(I need to use the client side of your library for an other project, perhaps I will come back ;-P )

Answer 7 · 2014-05-14T15:24:01.000Z

Updated. If you have time - try using the code from feature branch in your project. I'll merge and release the updated version soon.

Answer 8 · 2014-05-14T15:40:17.000Z

Ok,
I test it now !

Answer 9 · 2014-05-14T15:56:40.000Z

It works ! (I try VLC)
I have renamed the method call ssdp.serve() to ssdp.start().
I will test tonight with a real upnp client, but I think it's OK.

Answer 10 · 2014-05-19T20:10:56.000Z

Fixed in v1.0.0.