diversario/node-ssdp

M-Search Host header

Closed this issue · 6 comments

The spec says the Host header must be 239.255.255.250:1900, but the default config of node-ssdp sends 0.0.0.0:1900 the first time, but the next messages (as seen by TRACE logging) send the correct host.

screen shot 2014-06-07 at 10 52 32 am

Which version are you using?

The latest on npm.

I'm a little pressed on time at the moment so I didn't have time to look at it. There's a v2.0.0 on npm now, would you mind trying that to see if this bug was fixed there? There's an interface change in client event signature.

In the meanwhile, can you provide a gist demonstrating the error? I had no luck reproducing it on v1.1.0 so far.

muka commented

Hello, I've noticed this too.
I've changed it so the m-search goes mulitcast instead of unicast (to itself?)

@muka Yep. But NOTIFY event needs to be fixed too.

Can you update your PR to change just one line in lib/index.js:

this._ssdpServerHost = this._ssdpIp + ':' + this._ssdpPort

?

This way both client and server have their HOST set to 239.255.255.250:1900.

muka commented

Ok thanks, updated