diverta/front_next_media

Styling minor fixes

Closed this issue Β· 4 comments

VortexExpansion commented

@KuriharaMina san, can you have a look at these please ?

@HisashiHasebe

KuriharaMina commented

@VortexExpansion @HisashiHasebe
I have made the corrections, so please review. Thank you.

・Console warnings for image
a7030d4

・AlertError style
b8f55fa

  • πŸ‘€1
VortexExpansion commented

@KuriharaMina san

AlertError style seems perfect. Thank you ✨
The previous warnings seems to have been resolved too, but I can see a new warning on my local now for flex
https://diverta.gyazo.com/ec4dbcf9960bb58b83ecffb388925c6d

Edit : Found another one https://diverta.gyazo.com/90307c8aea5dc8f2c665b4a9e70625ec

Can you check please ?

VortexExpansion commented

@yabe-diverta san can you please take a look

yabe-diverta commented

No errors found now in the latest PR

evidences

browser

both build & dev do not emit warnings/errors 
~/w/front_next_media ❯❯❯ npm run build

> next-media@0.1.0 build
> next build

   β–² Next.js 14.1.4
   - Environments: .env.local, .env

   Creating an optimized production build ...
 βœ“ Generating static pages (51/51) 
 βœ“ Collecting build traces    
 βœ“ Finalizing page optimization    

Route (app)                              Size     First Load JS
β”Œ β—‹ /                                    186 B          96.5 kB
β”œ β—‹ /_not-found                          0 B                0 B
β”œ β—‹ /article                             2.42 kB        98.7 kB
β”œ ● /article/[id]                        1.87 kB        98.2 kB
β”œ   β”œ /article/39
β”œ   β”œ /article/22
β”œ   β”œ /article/16
β”œ   β”” [+31 more paths]
β”œ β—‹ /contact                             3.02 kB        94.3 kB
β”œ ● /feature/[id]                        903 B          97.2 kB
β”œ   β”œ /feature/20
β”œ   β”” /feature/17
β”œ β—‹ /login                               2.17 kB        93.5 kB
β”œ β—‹ /member/delete                       2.55 kB        93.8 kB
β”œ β—‹ /member/edit                         2.93 kB        94.2 kB
β”œ ● /member/limited/[id]                 2.16 kB        93.5 kB
β”œ   β”” /member/limited/[id]
β”œ β—‹ /member/mypage                       2.91 kB        99.2 kB
β”œ β—‹ /privacy                             175 B          91.5 kB
β”œ β—‹ /register                            2.47 kB        93.8 kB
β”” β—‹ /reminder                            1.66 kB          93 kB
+ First Load JS shared by all            91.3 kB
  β”œ chunks/69-c9cacc90c736f315.js        29.2 kB
  β”œ chunks/fd9d1056-d56d421cdc185422.js  53.4 kB
  β”” other shared chunks (total)          8.74 kB


β—‹  (Static)  prerendered as static content
●  (SSG)     prerendered as static HTML (uses getStaticProps)

~/w/front_next_media ❯❯❯ npm run dev

> next-media@0.1.0 dev
> next dev

   β–² Next.js 14.1.4
   - Local:        http://localhost:3000
   - Environments: .env.local, .env

 βœ“ Ready in 1909ms