divvun/divvun-dev-keyboard

Keyboards crashing

Closed this issue · 5 comments

snomos commented

At least the following keyboards are crashing when activated:

  • Meänkieli/fit
  • Runic Nynorsk/nn-Runr
  • Livvi/olo
  • South Sámi

iOS version: 17.5.1
Model: XS Max

@zoomix this is high priority.

snomos commented

Here's a video showing a number of issues including crashes, with oral comments.

SteffenErn commented

WIP:
Livvi/olo cashes on iOS due to an issue with the KeyboardDefinitions.json file
BaseKeyboard/KeyboardViewController.swift:250: Fatal error: Error getting keyboard definitions from json file: keyNotFound(Keys(stringValue: "normal", intValue: nil), Swift.DecodingError.Context(codingPath: [_JSONKey(stringValue: "Index 9", intValue: 9), Keys(stringValue: "ipad-9in", intValue: nil)], debugDescription: "No value associated with key Keys(stringValue: \"normal\", intValue: nil) (\"normal\").", underlyingError: nil))
However during build process this file is correct. Investigating further...

SteffenErn commented

This happens because Livonian does not have keyboard definitions for iPad. Either those definitions get added, the keyboard removed from the app or the app changed so it doesn't crash on missing ipad definitions.
@snomos What should we do?

SteffenErn commented

This commit fixes the crashing keyboards. New version of the dev app is submitted to app store and should be available soon

snomos commented

Looks almost good:

  • Livonian keyboard is now available and working on iPhone
  • no crashes detected after a short period of testing

There are still non-crashing issues on the iPad, see #4.