django-cms/djangocms-link

'NoneType' object has no attribute 'node'

joeljv91 opened this issue · 7 comments

joeljv91 commented

Hi,

I updated djangocms-link from version 2.1.2 to 2.2.1 and I get this error when I enter to some page I get this error:

screenshot 2018-11-23 at 10 08 08

I need to migrate any data which affect to this update?

I'm using DjangoCMS 3.5.3 and this plugin djangocms-bootstrap4 1.2.0 which inherits from your djangocms-link.

Thanks

joeljv91 commented

it does not matter I just saw the pull request:

#153

  • 👍2
avryhof commented

What bothers me is that this bug made it into a release. I could probably make the code in my PR cleaner if I had time to figure out what else it might break to do so.

  • 👍3
fsbraun commented

I had to revert to a previous version (2.1.2) of djangocms_link until this is fixed ... I'd appreciate if the fix is released quickly. Thanks very much!

joeljv91 commented

@avryhof I agree with you... @fsbraun for the moment the best solution is revert to 2.1.2

FinalAngel commented

@joeljv91 has the issue been resolved for you using 2.2.2?

  • 👍1
fsbraun commented

@FinalAngel It does for me, however, would it make sense to also replace ref_page.site_id by ref_page_site_id in line 151 of models.pyafter going through the hassle of detecting the node to get the site id?

FinalAngel commented

@fsbraun I'll have a look :)

  • 👍1