django-cms/djangocms-link

Issue or browser/OS behaviour when editing a link?

marksweb opened this issue · 4 comments

I've just had an issue raised with regard to editing an existing link in the editor.

If you double click on a link & the link dialog opens with only a part/word of the link selected, when you hit OK and save the link, it replaces the selected part of the link only. I'm not sure if that's easy to understand, so let me explain; if you have a link called click here and double click to edit it in the editor and the link dialog opens with only here selected, once you hit OK to save, the editor will then display click click here.

Is that initial selection behaviour controlled by the browser/OS or should the CKeditor/CMS ensure the whole link is selected when making the edit?

jsma commented

There is a similar issue reported for cmsplugin-filer link plugin. I've experienced this as well, have not had a chance to debug. Might need to rethink requiring a double click on the linked text as the UI...works fine for initial creation but attempts to edit are a pain for exactly the reasons you mention. Perhaps something similar to what GMail/Google Docs does where a pop-up appears that allows to change/remove the link.

screen shot 2015-07-23 at 6 10 29 pm

this issue has been resolved with the new djangocms-text-ckeditor preview functionality in 3.1.0

@jsma and @marksweb please check it out :)

Thanks @FinalAngel. Unfortunately I've been moved off CMS projects for a while, but I'll try to find time to look at that. I bet we won't be able to update at the moment though as most sites are running old versions of CMS 3.1.x

jsma commented

The recent updates do seem to solve these issue.