django-daiquiri/daiquiri

BUG: spoint issues

Opened this issue · 5 comments

It seems that spoints are not properly downloaded or uploaded.
need further investigation.

I get a char(32) for spoint which is too small to properly describe the position (losing the second parenthesis.

I could identify the issue coming from downloading. The generation of spoints fails in form of VOTable.

The issue is due to the fact that the postgres spoint type is translated into char(32).

this is coming from the default datatype being char(32) see: daiquiri/core/adapter/database/postgres.py

It seems that a solution could be to add a DATATYPE spoint in daiquiri/core/adapter/database/postgres.py

and check for () in

def _parse_column(self, row):
to identify spoint type rows.

upload catching is solved but #160

Downloading still need to be solved

The issue concerns all adql datatypes, such as CIRCLE, POLYGON, BOX, etc. we have to fix the issue ASAP in order to be compatible with ADQL. Otherwise, there is no way for the user to retrieve complete results via TAP.

Curiously enough, the downloaded files via the web interface don't experience the same issue, the results are not cut off at 32 char values.