django-getpaid/django-plans

Automatic publish to PyPI

Alir3z4 opened this issue · 18 comments

Alir3z4 commented

For each release, the package should be automatically published to PyPI.
Github actions can be triggered by each tag, once a tag is created on the repository, an action can get executed and publish to PyPI.

Blocked by: #133

PetrDlouhy commented

@Alir3z4 Should I somehow help with this?

I think we should make a PyPI release as soon as possible (automatic or not), because there are many fixes, especially of compatibility with newer Django versions. The new release should include MRs #155, #154, #152, #151, #149 (all are mostly bugfixes).

PetrDlouhy commented

@Alir3z4 Could you please merge the #158 and #152 MRs?

What about the PyPI release? Can I help it somehow?

PetrDlouhy commented

@Alir3z4 I think we should release new PyPI version now, the current doesn't work in with newer Django/Python versions.
None of the remaining MRs are mandatory for the new release (although #159 may be nice).

Alir3z4 commented

I cannot setup automatic publishing to PyPI unless my privileges gets escalated so I can add environment variables for Twine.

Probably @cypreess can help with that or he can add his own credentials to the GitHub Actions environment variables.
I've already done something like this in another project of mine at https://github.com/Alir3z4/python-currencies/blob/master/.github/workflows/python-publish.yml

alamothe commented

Any updates?

nemesifier commented

@PetrDlouhy @Alir3z4 @cypreess Hi there, sorry to bother you, but a new version of this package hasn't been released for over 4 years now, even though there has been active development recently.

Can anyone suggest a way to overcome this impasse?
I am ready to do my part, which is to help with the bare minimum maintenance tasks (updating support for newer django versions and fixing critical bugs).

PetrDlouhy commented

@nemesisdesign I have no rights to this repo nor PyPI package, so its on @Alir3z4.

I did most of the maintanence work as well as some development.
I think the project is mostly ready for new release.

There are PRs I have made that might be good to pull before release (but it is not needed):

  • #173 But it fixes only the demo app, so no change for production usage.
  • #172 Fix for tests, no change in production usage.
  • #162 Change in Billing info. Not needed for release.
cypreess commented

@PetrDlouhy @nemesisdesign I invited both of you with Writers privileges into this project, so please continue to maintain this repository and merge all PRs that you feel are appropriate.

I am sadly not able to maintain this project anymore.

cypreess commented

I also do not have for some unknown reasons privileged to PyPi project, @Alir3z4 can you maybe check this out as you have access and make all of us here maintainers on PyPI as well.

nemesifier commented

Thanks @cypreess for granting access.

I already merged #173 since it's a safe and small change, then reviewed #172.

Alir3z4 commented

@cypreess the only person alongside me that has access on PyPI is https://pypi.org/user/swapps/

Can you all give me your PyPI usernames to give everyone access?

PetrDlouhy commented

My PyPI username is petr.dlouhy

Alir3z4 commented

My PyPI username is petr.dlouhy

Invited.

PetrDlouhy commented

OK, I resubmitted #172 in #174 to use mocking everywhere.
The new version is still not released. Are we waiting for something, or should I just release it?

nemesifier commented

@PetrDlouhy have you got access to pypi to issue new releases?

PetrDlouhy commented

Yeah, now I have the rights. I will make the release.

PetrDlouhy commented

New version is now released. Please write if there are any problems with it.