When doing a patch operation on admin/product, images are inserted rather than updated.

[benmehlman]

When doing operations on 'admin/product', most behavior is as expected.. if you do a POST, the product is inserted, if PATCH, the fields supplied update the existing record, if DELETE, the product is deleted.

Except for the images field. If you supply a list of images to a patch, it does not replace the previous list of images. Instead, the images are inserted alongside the existing images.

In my application I have a back-end system which contains all the product data including images and periodically I want to update oscar with any new products or changes to old products.. this includes images.

The problem is that when I do a PATCH of the product, it does not delete any existing product images that are no longer valid. The result is a superset of old and new images.

The only workaround I have found for this is to DELETE and then POST.. which is bad because it changes the URL of the product, breaking any links, search engine indexes, bookmarks, etc...

Thanks
Ben

[specialunderwear]

Hi Ben, You might be confusing PATCH with PUT. Where Both are used for updates, PUT updates the entire record, which is what you want. And PATCH is used to perform partial update, which is why it not removing any images. So to do what you want, use PATCH.

…

Op 13 dec. 2021 om 20:21 heeft Ben Mehlman ***@***.***> het volgende geschreven: When doing operations on 'admin/product', most behavior is as expected.. if you do a POST, the product is inserted, if PATCH, the fields supplied update the existing record, if DELETE, the product is deleted. Except for the images field. If you supply a list of images to a patch, it does not replace the previous list of images. Instead, the images are inserted alongside the existing images. In my application I have a back-end system which contains all the product data including images and periodically I want to update oscar with any new products or changes to old products.. this includes images. The problem is that when I do a PATCH of the product, it does not delete any existing product images that are no longer valid. The result is a superset of old and new images. The only workaround I have found for this is to DELETE and then POST.. which is bad because it changes the URL of the product, breaking any links, search engine indexes, bookmarks, etc... Thanks Ben — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[specialunderwear]

I meant to say use PUT lol

…

Op 13 dec. 2021 om 21:18 heeft Lars van de Kerkhof ***@***.***> het volgende geschreven: Hi Ben, You might be confusing PATCH with PUT. Where Both are used for updates, PUT updates the entire record, which is what you want. And PATCH is used to perform partial update, which is why it not removing any images. So to do what you want, use PATCH. > Op 13 dec. 2021 om 20:21 heeft Ben Mehlman ***@***.***> het volgende geschreven: > > When doing operations on 'admin/product', most behavior is as expected.. if you do a POST, the product is inserted, if PATCH, the fields supplied update the existing record, if DELETE, the product is deleted. > > Except for the images field. If you supply a list of images to a patch, it does not replace the previous list of images. Instead, the images are inserted alongside the existing images. > > In my application I have a back-end system which contains all the product data including images and periodically I want to update oscar with any new products or changes to old products.. this includes images. > > The problem is that when I do a PATCH of the product, it does not delete any existing product images that are no longer valid. The result is a superset of old and new images. > > The only workaround I have found for this is to DELETE and then POST.. which is bad because it changes the URL of the product, breaking any links, search engine indexes, bookmarks, etc... > > Thanks > Ben > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or unsubscribe. > Triage notifications on the go with GitHub Mobile for iOS or Android.

[benmehlman]

Ok I see, thank you I will try it now.

In my view, specifying "images" in a patch should semantically speaking replace the old value of "images". But since I'm updating the whole record anyway, using PUT should be fine.

[specialunderwear]

If we would do it like that, there would be no way to partially update the images.