Tracker._get_or_create_player should not be a private method
djcunningham0 opened this issue · 0 comments
djcunningham0 commented
Tracker._get_or_create_player (or _create_new_player) should be a public method. There are legitimate use cases where the user of the package would want to call this method, such as when you are implementing a more complicated system with additional logic that can't be handled by Tracker.process_data.
Low priority because the use case is rare and methods are never really private in Python anyway (it's just more difficult for users to discover this method).
multielo/multielo/player_tracker.py
Line 331 in 440f792