djluck/PromQL.Parser

Can't use _sb in Printer when overriding methods

Closed this issue · 3 comments

oyosefi commented

First, thank you for creating this library. It's great.
I'm writing on a small utility that automatically updates Grafana dashboards so I can easily import them without too much manual tweaking.
One of the changes I wanted to do is replace duration to be $__rate_interval.
I could easily do this by overriding the Duration visitor in the Printer class, but because _sb is private, I can't change the logic (which expects a timespan)

I'd like to suggest making the access modifier for _sb to be protected to allow use by overriding methods

djluck commented

Thanks @oyosefi!

I did leave a protected method Write available for this reason, does that work for you? I'd prefer to expose specific functionality vs the entire StringBuilder.

oyosefi commented

Oh, I missed that. That works perfectly. Thanks again @djluck