Java findbugs - nullcheck of value previously dereferenced
Opened this issue · 1 comments
GoogleCodeExporter commented
The code does not run cleanly though FindBugs because of some bugs:
In org/poly2tri/triangulation/delaunay/sweep/DTSweep.java at lines 634, 789,
the 'if(ot == null)' checks are made after 'ot' is dereferenced. This condition
can never be true because a NullPointerException would be thrown on the lines
before.
Original issue reported on code.google.com by d22...@gmail.com
on 21 Jan 2015 at 12:03
GoogleCodeExporter commented
Yeah those two ot=null checks can be removed. I kept them just to be a reminder
of where I had to add code if I wanted to include the filling of missing
triangles during the constrained edge phase. Now the filling is done separately
before the edge phase.
I should have commented out those ot=null tests when keeping them as a reminder.
Original comment by thahlen@gmail.com
on 21 Jan 2015 at 1:21