dlee13/hold-that-chunk

Ignore server render distance doesn't enable unless on main menu

Closed this issue · 4 comments

When attempting to enable the "Ignore server render distance" option while in a multiplayer session, the Enabled status of the button resets and the behavior does not change. It only actually enables from the main menu.

dlee13 commented

That is working as intended. The client sets the render distance upon receiving the login packet, so it takes rejoining the server for the change to take effect anyways.

There should be a warning message about what you said then, or the option should be greyed out when it is not available to be changed, rather than silently failing to enable. For players that don't understand how it works, they may be confused and think the mod isn't behaving correctly.

dlee13 commented

When you have YACL installed but not Cloth Config, the YACL screen is used and that option is disabled like you suggested. However, when you have Cloth Config installed, the Cloth Config screen is used instead. And Cloth Config doesn't have any API to disable options. I'll consider adding a tooltip to that.

dlee13 commented

Fixed in commit 95b356a

The option gets disabled when it cannot be changed.