dm-vdo/vdo

Little typo ?

tigerblue77 opened this issue · 6 comments

tigerblue77 commented

Hello there,

I'm compiling VDO for use on Debian 11.3 (kernel 5.10.0-3) using the following command :

git clone https://github.com/dm-vdo/vdo.git /tmp/vdo/ && \
cd /tmp/vdo/ && \
make -j$(nproc)

And got this little echo error :

image

which comes from utils/vdo/Makefile:116

image

I'm not a bash expert but, why is this double "$$" ? And this line ?
Apparently, my compiler doesn't like it, but it compiles well.

Have a nice day,

lorelei-sakai commented

Thank you for reporting this. It is indeed a typo. It will be fixed in the next update.

The line is merely informational, so you can ignore it. As you noted, it does not affect the compilation.

  • 👍1
tigerblue77 commented

You're welcome, thanks for your reply.

So will you remove the entire line or only replace the "$$" by "$" ?
Out of curiosity, was there a reason for "$$"?

lorelei-sakai commented

I was going to just fix the typo, but on reflection the extra output isn't very useful, so I will remove it.

The $$ appears to have been a simple typo, nothing more. $$ has a meaning in makefiles, but it doesn't make any sense here.

tigerblue77 commented

I do agree, thanks for the detailed explanation.
Have a nice day

tigerblue77 commented

Hello @lorelei-sakai,
Is this issue fixed now ? If yes, feel free to close it :)

slegendr commented

Hello @tigerblue77 ,
I have confirmed that the issue is fixed. Thank you for your attention to detail and for reporting it. :)

  • 👍1