Various properties gone missing in 0.3.3
deepxg opened this issue · 7 comments
This might be me abusing the API, in which case my apologies, but upgrading from 0.3.2 to 0.3.3 has lost various useful properties and keys I was relying on. For example the property :minute-of-day no longer exists, and as-map not longer returns :instant-seconds. If there are more canonical ways to retrieve these I'd appreciate a pointer!
Thanks for the report! This is caused by #51. There were no tests checking whether all properties present before the PR remained available afterwards. This is definitely a bug and not something intentional. Please stay on 0.3.2.
Would also be helpful if you have a list of all the properties that you've relied on. There are two options now:
- Revert the PR - should be minimal impact as the main goal of the PR - decreasing load time - didn't realize.
- Add all the properties to the static list manually
Given that I'm not actively working with Clojure anymore, I'm leaning towards 1.
We also lost two properties:
:aligned-week-of-year and :minute-of-hour
They weren't tested in
clojure.java-time/test/java_time_test.clj
Line 769 in 78cecf3
There doesn't seem to be a 0.3.4 version in clojars? I see a changelog entry that fixes this though.
Any idea when the next release might be out? I came here to open an issue about this because I was running into exceptions trying to get the :minute-of-hour from a ZonedDateTime, but it looks like this will be fixed in the next release already if I am reading this right.
@brunchboy no sorry, waiting on #84 (comment)
Ah, that makes sense! Fingers crossed you will get access soon; in the mean time, I will do things the old, Java interop way.