dm3/clojure.java-time

Case bug in https://github.com/dm3/clojure.java-time/blob/master/src/java_time/format.clj#L32

orestis opened this issue · 1 comments

@borkdude and myself were discussing adding a linter to clj-kondo about case statements with symbol arguments, and during some code searches we found this:

https://github.com/dm3/clojure.java-time/blob/master/src/java_time/format.clj#L32

(defn- get-resolver-style [s]
  (cond-> s
    (not (instance? ResolverStyle s))
    (case
      :strict ResolverStyle/STRICT
      :smart ResolverStyle/SMART
      :lenient ResolverStyle/LENIENT)))

The case statement should probably start with s as the first argument :)

Whoops! Our carve logic didn't quite work :) Disregard please!