path issues on windows
Closed this issue · 3 comments
davehorner commented
fyi
c:\w\demos>git clone https://github.com/dmackdev/egui_json_tree.git
Cloning into 'egui_json_tree'...
remote: Enumerating objects: 1995, done.
remote: Counting objects: 100% (423/423), done.
remote: Compressing objects: 100% (258/258), done.
remote: Total 1995 (delta 183), reused 191 (delta 163), pack-reused 1572 (from 2)
Receiving objects: 100% (1995/1995), 2.46 MiB | 6.98 MiB/s, done.
Resolving deltas: 100% (1227/1227), done.
error: invalid path 'egui_json_tree/tests/snapshots/changing_default_expand/2_SearchResults("gree").png'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
dmackdev commented
Many thanks for raising this, looks like when I added snapshot images I named some with invalid Windows filenames!
I will fix this right away.
dmackdev commented
@davehorner I have just merged changes to address this, and also included a GH Actions job to check the repo/code on Windows. I can see that from the recreating the error on this job before the file renames, and then a successful job result following the file renames, that this issue should be now resolved. But, if you still are encountering a filename problem after pulling from main, feel free to reopen this issue.
davehorner commented
tested. working. thanks for fixing!