A single space, a BUG?
Closed this issue · 3 comments
zhangchen-qinyinghua commented
Check the code here,
https://github.com/dmlc/mshadow/blob/master/mshadow/tensor_blob.h#L320
is different from code here,
https://github.com/dmlc/mshadow/blob/master/mshadow/tensor_cpu-inl.h#L40
there is a small space after the comma.
I think that will give rise to some troubles.
For example, if I use:
TShape shape=mshadow::Shape2(5,5);
std::stringstream ss;
string s;
ss<<shape;
ss>>s;
//s is (5,
zhangchen-qinyinghua commented
It's not big deal, but will make some behaviors confusing.
tqchen commented
oh, thanks for pointing this out, let us make it consistent, can you submit a pr?
zhangchen-qinyinghua commented
@tqchen
Sure, I am glad to.