dmlc/mshadow

Some misleading syntax

Jokeren opened this issue · 1 comments

In Dot_engine-inl.h, the default type of a template argument is set by

template<typename Device, typename DType = default_real_t>

While in other places like Tensor.h, I notice that DType is set by #define MSHADOW_DEFAULT_DTYPE = default_real_t.

Should we define them in a consistent way?

szha commented

This code base has been donated to the Apache MXNet project per #373, and repo is deprecated. Future development and issue tracking should continue in Apache MXNet.