dmouse/vimeo-field

change namd without _

Closed this issue · 7 comments

maybe vimeo-field is a better name

Why?
Maybe vimeoField?

vimeo-field is better as repo, more standard, i think _ is a bad practice in composer packages

Yes, but in Drupal this is correct, I'm not sure yet so I'll leave well for now

no, i mean you have the freedom on your module, actually this is encouraging very bad practices in terms of the names because your module will become namespaces, it is doable but it is the same situation how the package names have evolved in packagist, http://packagist.org/ check the package names and what is the norm, the more packages you will see. Ultimately you want your packages (aka modules) be registered in packagist. I do hope drupal makes decoupled modules in a way that they are reusable even outside of drupal. When that day comes please I hope we don't have these bad naming things still lingering.

Of course, I know about the packagist, but for this very reason, this module will hardly run out of Drupal. If it were a library would be in total agreement rename.

the thing is modules are installable in a php context, check the drupal/console it is installable with composer, and in composer packages are free, but names are more lower-cased and with dashes. Is debatable but imo is a big mistake to make the name drive and not fit into a convention that is more widely open. Later on you could decouple your module from a library that gets used by the module.

Sure, if this module will create a library for process videos or any other functionality. I think we will decouple the library and this module only should be a wrapper