ellipse.default(): center has no effect
Closed this issue · 4 comments
dwoll commented
Many thanks for developing ellipse
and for putting the source on GitHub! I'm wondering if the addition of argument center
is as intended. centre
is used on line 27/28
Line 27 in e41ef76
However, there is no previous assignment centre <- center
conditional on center
being supplied but not centre
. Consider
> e1 <- ellipse:::ellipse.default(0.8, center=c(1, 2))
> e2 <- ellipse:::ellipse.default(0.8, center=c(0, 0))
> all.equal(e1, e2)
[1] TRUE
Using centre
instead really gives different ellipses.
Note there is a typo in the warning on line 7 (one should be center
)
Line 7 in e41ef76
Thanks in advance!
dmurdoch commented
Yes, you're right. I'll fix it.
dmurdoch commented
Now fixed. I'll wait a few days to see if anything else turns up before sending this to CRAN.
dwoll commented
Thank you very much!
dmurdoch commented
Just accepted by CRAN. Thanks for the report!