do-know/Crypt-LE

"Failed to save a CSR" is not fed to $opt->{'error'}->(...) before being returned

guest20 opened this issue · 5 comments

It seems like all the other "Failed to write" errors are wrapped in something like:

            return $opt->{'error'}->("Failed to save a CSR key", 'CSR_SAVE') if _write($opt->{'csr-key'}, $le->csr_key);

but some how this one is just returned as a bare string:

return "Failed to save a CSR" if _write($opt->{'csr'}, $le->csr);

I'm sure this would cause the script to die with "not a hash-ref" in &main if I were running bin/le.pl like a normal person

Thanks for flagging, will have a look.

Should be fixed on the upcoming version (available on the 'beta' branch now)

Neat!

Pushed v0.39, which includes the change.

I guess this is the "Minor fixes" part in the Changes