semantic_flash_helper with string hash keys
Closed this issue · 1 comments
jaredmoody commented
semantic_flash helper does not properly catch flash['alert']
as it's only checking for the symbol version, flash[:alert]
This is problematic for me because Devise uses string keys.
Easy fix is to use to_sym
before the checks:
type = :success if type.to_sym == :notice
type = :error if type.to_sym == :alert
I was working on a pull request but went to write specs and ran into #12. Will submit PR including new specs once that ticket is resolved.
jaredmoody commented
I think this should still be open unless there's been a change made so that semantic_flash
catches string keys.