docker-flow/docker-flow-swarm-listener

Docker version(s) tested for Docker Flow services

Closed this issue · 6 comments

This is a question more than anything else. When tests are run against Docker Flow services (including DFSL but also DFP and DFM, since there are "dependencies" amongst them), which against which versions of Docker are they tested?

I ask because I was browsing the Docker for Linux issues recently in relation to DFSL issue #3, and I noticed an issue filed about memory leaks in 18.03.1-ce, and it got me wondering if these are related. Even if they aren't, now I'm curious how tests and versions work for the Docker Flow stack of services.

It's tested against a single Docker version only. It would be too costly for the project to spin up, let's say, ten VMs to test with ten versions on every commit.

Yes, of course, that is completely reasonable! Is it the latest stable version, the latest edge version, or does it vary?

It's the latest stable version.

VMs are created from AMIs built with Packer. The definition is in https://github.com/vfarcic/docker-flow-hub/blob/master/packer/test-cluster.json.

I just built a new image so, starting from the next commit, it'll be Docker 18.03.

Hi @vfarcic, yes, I see. Latest stable version is great. Would it make sense to add this information to the DFSL Dockerfile so that it is incorporated into the Docker image?

I'm not sure what you mean by adding the information to DFSL Dockerfile. It does not use any specific Docker version.

I was thinking something like a LABEL com.df.testedDockerVersion=v18.03.1-ce in the Dockerfile ... in hindsight, I'm not really sure how useful that would be. If anything would be a concern as it relates to Docker version, it would probably be the Docker API version in use ... and even then, I'm not sure how much that would matter, since Docker has communicated that they basically expect users to be no more than one stable release behind the current stable release.

Feel free to close this. Was trying to offer a helpful suggestion but its actually just more confusing.