Remove opcache.fast_shutdown from PHP settings section

When checking the Dockerfile in this repo to see if it had relevant ideas or settings I could use for a Dockerfile of my own, I noticed the opcache.fast_shutdown being used. After looking it up however, I found out this directive has been removed since PHP 7.2.0 (see https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.fast-shutdown). So it may as well be removed from the settings here.

Oh neat. Yeah seems reasonable to drop it from the Dockerfiles:

drupal/Dockerfile.template

Lines 78 to 86 in 31babf9

    
           # set recommended PHP.ini settings 
        
           # see https://secure.php.net/manual/en/opcache.installation.php 
        
           RUN { \ 
        
           		echo 'opcache.memory_consumption=128'; \ 
        
           		echo 'opcache.interned_strings_buffer=8'; \ 
        
           		echo 'opcache.max_accelerated_files=4000'; \ 
        
           		echo 'opcache.revalidate_freq=60'; \ 
        
           		echo 'opcache.fast_shutdown=1'; \ 
        
           	} > /usr/local/etc/php/conf.d/opcache-recommended.ini

I guess upstream should update their documentation as well (https://www.php.net/manual/en/opcache.installation.php), since that is where it came from.

Yeah I thought about that, but I think the policy on their docs is currently to document everything back to version 7.0.0, so they might not want to do that yet. I'll raise an issue over there just in case.

Edit: see php/doc-en#2172.

	# set recommended PHP.ini settings
	# see https://secure.php.net/manual/en/opcache.installation.php
	RUN { \
	echo 'opcache.memory_consumption=128'; \
	echo 'opcache.interned_strings_buffer=8'; \
	echo 'opcache.max_accelerated_files=4000'; \
	echo 'opcache.revalidate_freq=60'; \
	echo 'opcache.fast_shutdown=1'; \
	} > /usr/local/etc/php/conf.d/opcache-recommended.ini